Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict to matplotlib<3.8 until we fixed typing (#561) #561

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Sep 15, 2023

resolves #560

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9a10c04) 100.00% compared to head (97154ad) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #561   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2152      2152           
  Branches       532       532           
=========================================
  Hits          2152      2152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take this first, as I have small change requests for #563

@dkrako dkrako merged commit 0cb6974 into main Sep 22, 2023
@dkrako dkrako deleted the hotfix-matplotlib-mypy branch September 22, 2023 05:28
@dkrako dkrako changed the title fix matplotlib<3.8 until we fixed typing fix: restrict to matplotlib<3.8 until we fixed typing (#561) Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected mypy error in matplotlib functions in plotting
2 participants